-
Couldn't load subscription status.
- Fork 141
Add workflow to validate UBI images pass RedHat Certification #4035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4035 +/- ##
=======================================
Coverage 86.00% 86.01%
=======================================
Files 131 131
Lines 14063 14063
Branches 35 35
=======================================
+ Hits 12095 12096 +1
+ Misses 1769 1768 -1
Partials 199 199 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…on in matrix of images
|
@ciarams87 I noticed that the preflight binary has a `--certification-component-id`` flag which uses something called the component PID. I looks like NIC has this too in their workflow. I'm not sure if this is something we should add now or it should be appended later when we want to do the "full" certification workflow |
@shaun-nx We need that when we want to submit the results to the RH partner portal - the component ID is how it knows what product to link the results to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to have another think about this now that the release is done and I have more context.
For one think, I think maybe instead we should run this in the nightly instead, no need for every PR.
We should also add the option to submit the images for releases.
It might be worth investigating if we can move this into a shared location for NIC and NGF to use, as we are both doing the same thing now
Proposed changes
This change adds a new workflow file,
openshift-certification.ymlwhich is responsible for validating that our UBI based images of NGF, NGINX OSS, and NGF Operator will pass the RedHad certification process.This workflow uses RedHat Openshift Preflight tool to pre-certify images before they are published:
https://github.com/redhat-openshift-ecosystem/openshift-preflight
Closes #3909
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.